Fix #7048: PCP heal path dependent types #7386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#7048-2
branch
3 times, most recently
from
5f695f5 to
77081ec
Compare
nicolasstucki
requested review from
odersky and
liufengyun
and removed request for
odersky and
liufengyun
nicolasstucki
commented
Oct 8, 2019
nicolasstucki
commented
Oct 8, 2019
odersky
requested changes
Oct 9, 2019
| def isStaticPathOK(tp1: Type): Boolean = tp1 match { | ||
| case tp1: TypeRef => tp1.symbol.is(Package) || isStaticPathOK(tp1.prefix) | ||
| case tp1: TermRef => tp1.symbol.isStaticOwner || isStaticPathOK(tp1.prefix) | ||
| case tp1: ThisType => tp1.tref.symbol.is(Package) || tp1.tref.symbol.is(Module) |
There was a problem hiding this comment.
Typo: "porjection"
I don't think this is the right logic for isStaticPathOK. How about:
tp1.stripTypeVar match
case tp1: TypeRef => tp1.symbol.is(Package) || isStaticPathOK(tp1.prefix)
case tp1: TermRef => tp1.symbol.is(Module) && tp1.symbol.isStatic
case tp1: ThisType => tp1.cls.isStaticOwner
case tp1: AppliedType => isStaticPathOK(tp1.tycon)
There was a problem hiding this comment.
I used this version it but made a couple of extra changes to make all the tests pass
nicolasstucki
force-pushed
the
fix-#7048-2
branch
4 times, most recently
from
c1c8ead to
fc99492
Compare
nicolasstucki
force-pushed
the
fix-#7048-2
branch
from
fc99492 to
a3d351a
Compare
odersky
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'[p.X]wherepis statically known and therefore is phase consistent.'{ val x: p.X = ... }wherepis not phase consistent but there is a givenType[p.X]in scope.